Add DREQ methods for PWM/SPI/UART/I2C #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #563 |
lurch
reviewed
Oct 11, 2021
lurch
reviewed
Oct 11, 2021
lurch
reviewed
Oct 11, 2021
lurch
reviewed
Oct 11, 2021
| @@ -54,6 +54,10 @@ static inline void check_dma_channel_param(__unused uint channel) { | |||
| #endif | |||
| } | |||
|
|
|||
| static inline void check_dma_timer_param(__unused uint timer_num) { | |||
| valid_params_if(DMA, timer_num < NUM_DMA_TIMERS); | |||
There was a problem hiding this comment.
This particular branch seems to be missing the NUM_DMA_TIMERS definition.
Out of curiosity, why wasn't that picked up by the CI tests?
There was a problem hiding this comment.
i guess we aren't building a debug build in CI - we should be
There was a problem hiding this comment.
ping @liamfraser - Is it easy to modify our CI process to build both Release and Debug builds?
lurch
reviewed
Oct 11, 2021
lurch
reviewed
Oct 11, 2021
lurch
previously approved these changes
Oct 12, 2021
Wren6991
previously approved these changes
Oct 12, 2021
|
merged without new code review as i just rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.