This repository was archived by the owner on Mar 18, 2025. It is now read-only.
Support simple array options in x-select #89
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
x-select
component, simple array options are not being mapped correctly and causing errors to be thrown.This will cause the select to mistake them as "opt groups", and inside the
@foreach
loop on the option, it will throw an error because it will try to iterate over a string instead of an array.This PR will normalize the options the same way that
x-custom-select
does, and will fix this issue. Thex-select
component will no longer try to render them as opt groups.