-
-
Notifications
You must be signed in to change notification settings - Fork 195
Added Screenreader-Support with ariaId #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes Unknown when pulling 741e1bd on dsumer:master into ** on react-component:master**. |
Changes Unknown when pulling 04b560a on dsumer:master into ** on react-component:master**. |
I see you just attached an id attribute to div,how does help for aria? |
For example, if you have an input field with an Tooltip around it you have currently no chance to link them for accessiblity purpose. With this id field you can do it like this: <Tooltip
...
ariaId={this.props.name}
<input className={className}
type="text"
...
aria-describedby={this.props.name}/>
</Tooltip> Now the Screenreader will associate the input field with the tooltip and read its contents when you focus the input. |
So |
ok fine I will rename it to id .. then I will add an extra accesibility section to the README to describe how to work in harmony with screenreaders |
Changes Unknown when pulling b5e7030 on dsumer:master into ** on react-component:master**. |
Changes Unknown when pulling b5e7030 on dsumer:master into ** on react-component:master**. |
Changes Unknown when pulling b5e7030 on dsumer:master into ** on react-component:master**. |
Changes Unknown when pulling b5e7030 on dsumer:master into ** on react-component:master**. |
is this PR ready to be merged? |
me and my team are excited to see this in the next release of rc-tooltip :) |
Sorry for the late, published |
Added ariaId prop, which gets attached to the tooltips inner content container and can be used with aria-describedby for better accessibility and Screenreader-Support.