Skip to content

fix react createClass and PropTypes warning #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2017

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 14, 2017

if (this._component) {
return this._component.isMounted() ? this._component.getPopupDomNode() : null;
if (this._component && this._component.getPopupDomNode) {
return this._component.getPopupDomNode();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用 isMounted 会报错。

@coveralls
Copy link

Coverage Status

Coverage increased (+3.3%) to 81.616% when pulling 1e486ce on fix-react-15.5-warning into b9bb160 on master.

@afc163 afc163 requested a review from yiminghe April 14, 2017 10:09
@yiminghe yiminghe merged commit a4fec23 into master Apr 17, 2017
@yiminghe yiminghe deleted the fix-react-15.5-warning branch April 17, 2017 08:09
@afc163
Copy link
Member Author

afc163 commented Apr 18, 2017

把用例搞挂了:https://travis-ci.org/ant-design/ant-design/builds/222804823

没看明白..

@afc163
Copy link
Member Author

afc163 commented Apr 18, 2017

@yesmeck 来帮忙看看

@yesmeck
Copy link
Member

yesmeck commented Apr 18, 2017

Trigger 要加个 displayName 不然测试里找不到它。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants