Skip to content

feat: Add new trigger type --- 'contextmenu' #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 16, 2017

Conversation

MrPeak
Copy link
Contributor

@MrPeak MrPeak commented Oct 10, 2017

No description provided.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling fa57faf on MrPeak:master into ** on react-component:master**.

Copy link
Member

@benjycui benjycui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我没问题了,补充下文档就好。

@benjycui
Copy link
Member

cc @afc163

@@ -57,7 +57,7 @@ class Test extends React.Component {
maskClosable: false,
placement: 'right',
trigger: {
hover: 1,
contextMenu: 1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个别改吧,新建一个 demo。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

现在的demo就按照嵌入跟非嵌入划分的了

默认还是hover触发,我加到后面吧,contextmenu的场景应该相当少,没必要单独搞一个html吧

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@afc163
Copy link
Member

afc163 commented Oct 10, 2017

补个用例。

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 8cb5194 on MrPeak:master into ** on react-component:master**.

@MrPeak
Copy link
Contributor Author

MrPeak commented Oct 16, 2017

CC @afc163

@afc163 afc163 merged commit 495d444 into react-component:master Oct 16, 2017
@afc163
Copy link
Member

afc163 commented Oct 16, 2017

2.1.0

@afc163
Copy link
Member

afc163 commented Oct 26, 2017

@MrPeak

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants