Fix for latest iPad scrolling instead of dragging vertically.

[JaneCoder]

This is a fix for iPad, which has a flaw with vertical dragging related to the scroll bar. Other touch devices, even iPhone worked fine without the fix. This version uses the event helpers to add and remove the events.

[JaneCoder]

Unfortunately this version is failing for vertical drag on Lenovo touch screens in Firefox now. We will do some more testing and try to determine the cause.

[STRML]

I appreciate your tenacity! Browsers implement this spec very badly.

[JaneCoder]

This is looking good. We found that the tester had issues outside of our app with touch on chrome and firefox. Touch had to be re-enabled on her device. It was not related to the update to the ipad fix.

[STRML]

I'm going to review this when I get home - have an iPad laying around - I'll update when I am sure this is working. Thanks!

[JaneCoder]

Thank you for your wonderful work!

On Mon, Aug 29, 2016 at 1:03 PM, Samuel Reed [email protected]
wrote:

I'm going to review this when I get home - have an iPad laying around -
I'll update when I am sure this is working. Thanks!

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#183 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4yT59jvMosCbqQDPUveti46je6r83pks5qkxDugaJpZM4JYYYW
.

[JaneCoder]

Hello @STRML. Have you had a chance to test with your ipad? Please let me know if there is anything different you'd like me to do.

[nisjunk]

On iPadPro, all demos fail because the whole page also scrolls with the element. I think it is a show stopper issue.

[JaneCoder]

nisjunk, we have that issue with the original version, but not with this patched version which stops scrolling on drag.

PS we are using a version of this pull request from our bitbucket repo, and will continue with our own patched version until this is accepted or someone else puts in a fix the owners like.

[STRML]

Hi @JaneCoder,

Very sorry for how long it took to get to this.

I reviewed your fix and found that it fixed most use cases, but caused issues with bounded elements. After spending some time reviewing exactly how iOS handles touch events, I was able to very simply fix this in 8a51de9.

Thanks for reporting this!

[STRML]

This is published and in v2.2.3.

[JaneCoder]

Sweet! Thanks so very much!

On Mon, Nov 21, 2016 at 2:37 PM, Samuel Reed [email protected]
wrote:

This is published and in v2.2.3.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#183 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AC4yT8Pz3mTEWLq037sNpdH6vpZi0-Pxks5rAfMRgaJpZM4JYYYW
.