Skip to content

ci(macOS): Restore CI pipeline #502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2020
Merged

ci(macOS): Restore CI pipeline #502

merged 1 commit into from
Dec 4, 2020

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Dec 4, 2020

Summary

It looks like the macOS CI was accidentally deleted in #369. This change restores it.

Test Plan

macOS CI should pass.

@tido64 tido64 added the platform: macOS This is macOS specific label Dec 4, 2020
@tido64 tido64 force-pushed the tido/restore-mac-ci branch 7 times, most recently from 016f1de to 82b46de Compare December 4, 2020 14:20
@tido64 tido64 force-pushed the tido/restore-mac-ci branch from 82b46de to bd0099a Compare December 4, 2020 15:57
@tido64 tido64 marked this pull request as ready for review December 4, 2020 16:43
@tido64 tido64 requested a review from krizzu December 4, 2020 16:44
# Workaround for `Element StaticText, {{163.0, 836.0}, {156.0, 21.0}}, value: Set native delegate is not hittable`.
# This occurs when a button is not visible in the window. We resize the window
# here to ensure that it is.
defaults write com.microsoft.ReactTestApp "NSWindow Frame MainWindow" "0 0 800 500 0 0 2560 1417 "
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice hack 🤞

Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, probably removed by accident 🙈

@tido64 tido64 merged commit bfd76c7 into master Dec 4, 2020
@krizzu krizzu deleted the tido/restore-mac-ci branch December 6, 2020 20:48
@krizzu
Copy link
Member

krizzu commented Jan 18, 2021

🎉 This PR is included in version 1.13.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: macOS This is macOS specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants