Skip to content

Add info on where data is stored #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jackbridger
Copy link
Contributor

Summary

This is a docs change and relates to issue #905 - adding information on where data is stored.

I placed it under the advanced category in the sidebar. Let me know if you prefer it somewhere else.

CleanShot 2023-02-07 at 10 49 59

Test Plan

It is a docs change so likely just need to review that the docs run as they should. Let me know if you want me to do any other testing.

Thanks!!

Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this 👍

@tido64 tido64 linked an issue Feb 7, 2023 that may be closed by this pull request
@jackbridger
Copy link
Contributor Author

Everything should be updated now
CleanShot 2023-02-07 at 11 21 29

Copy link
Member

@tido64 tido64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@tido64 tido64 enabled auto-merge (squash) February 7, 2023 12:00
@krizzu
Copy link
Member

krizzu commented Feb 7, 2023

Thanks Jack 🙏
@tido64 seems like Windows cannot resolve some dependencies, again. I think we can just move this forward anyway.

@tido64 tido64 disabled auto-merge February 7, 2023 12:40
@tido64 tido64 merged commit 7adb803 into react-native-async-storage:master Feb 7, 2023
@jackbridger
Copy link
Contributor Author

Yay! Thanks both for your support. This was my first contribution to a project that lots of people use. Even though it's only docs, it feels good. Hope it's the start of more contributions. Thanks!!

@AsyncStorageBot
Copy link
Collaborator

🎉 This PR is included in version 1.17.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include information on the storage implemention
4 participants