Skip to content

Add Eslint and Prettier #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 3, 2020

Conversation

Naturalclar
Copy link
Member

@Naturalclar Naturalclar commented Jan 1, 2020

Summary

Added community eslint config/prettier and applied linting.

Test Plan

  • yarn lint

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

@Naturalclar Naturalclar changed the title Chore/add eslint Add Eslint and Prettier Jan 1, 2020
@Naturalclar Naturalclar requested a review from pvinis February 2, 2020 01:47
@pvinis
Copy link
Member

pvinis commented Feb 3, 2020

Can we keep the semis off?

@Naturalclar
Copy link
Member Author

@pvinis sure :)
It seems like @react-native-community/config sets semi as warn, which conflicts with prettier. So I had to add a rule in eslintrc in order to get rid of the semi colons.

Copy link
Member

@pvinis pvinis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pvinis pvinis merged commit 1ab42cd into react-native-community:master Feb 3, 2020
@Naturalclar Naturalclar deleted the chore/addEslint branch February 3, 2020 16:38
@pvinis
Copy link
Member

pvinis commented Feb 21, 2020

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants