Skip to content

use prettier by default #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Conversation

vonovak
Copy link
Contributor

@vonovak vonovak commented Feb 2, 2020

Summary

I removed "requirePragma": true from prettierrc because that option means prettier is not enabled unless explicitly turned on using the @format pragma.

After that I just ran eslint --fix and the code now follows the specified config.

Test Plan

  • eslint passes (it does locally :) )

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@vonovak vonovak requested a review from Naturalclar February 2, 2020 20:55
Copy link
Member

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM

@Naturalclar Naturalclar merged commit d7df774 into master Feb 3, 2020
@Naturalclar Naturalclar deleted the @vonovak/use-prettier-by-default branch February 3, 2020 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants