Skip to content

feat: Add alertTitle, repeatInterval to formatted notification #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2020
Merged

feat: Add alertTitle, repeatInterval to formatted notification #131

merged 1 commit into from
Jun 8, 2020

Conversation

lukebars
Copy link
Contributor

@lukebars lukebars commented Jun 8, 2020

Summary

Currently, when called method getScheduledLocalNotifications there are no fields to see title or repeatInterval of scheduled notification. This PR adds those missing pieces. I think it will be very helpful for managing local notifications.

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅
Android ❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@lukebars
Add alertTitle, repeatInterval to formatted notif
07de6a8 
This will be really helpful when managing notifications, e.g. seeing the list for scheduled notifications
@lukebars
Copy link
Contributor Author

lukebars commented Jun 8, 2020

cc @Naturalclar

@lukebars lukebars mentioned this pull request Jun 8, 2020
Merged
Naturalclar
Naturalclar approved these changes Jun 8, 2020
View reviewed changes
Copy link
Collaborator

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukebars Thank you so much <3

@Naturalclar Naturalclar changed the title Add alertTitle, repeatInterval to formatted notification feat: Add alertTitle, repeatInterval to formatted notification Jun 8, 2020
@Naturalclar Naturalclar merged commit 57f93cf into react-native-push-notification:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Naturalclar Naturalclar Naturalclar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukebars @Naturalclar