Added getCurrentRoutes functionality without the need of ref. #157
Conversation
|
@AsafBrieferyDev, thanks for your PR! By analyzing the annotation information on this pull request, we identified @SEthX, @charpeni and @AnNOtis to be potential reviewers |
|
+1 |
|
Looks good, can you fix eslint errors? |
|
Hi, Regards, On 7 Sep 2016, at 13:12, Nicolas Charpentier <[email protected]mailto:[email protected]> wrote: Looks good, can you fix eslint errors? — |
| @@ -285,6 +287,10 @@ class Router extends React.Component { | |||
| this.setState({ titleProps: props }); | |||
| }; | |||
|
|
|||
| const getCurrentRoutes = () => { | |||
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body. (arrow-body-style)
| @@ -285,6 +287,10 @@ class Router extends React.Component { | |||
| this.setState({ titleProps: props }); | |||
| }; | |||
|
|
|||
| const getCurrentRoutes = () => { | |||
| return this.refs.navigator.getCurrentRoutes() | |||
There was a problem hiding this comment.
Missing semicolon. (semi)
| @@ -234,7 +234,9 @@ class Router extends React.Component { | |||
| setTitleProps(props) { | |||
| this.setState({ titleProps: props }); | |||
| } | |||
|
|
|||
| getCurrentRoutes() { | |||
| return this.refs.navigator.getCurrentRoutes() | |||
There was a problem hiding this comment.
Missing semicolon. (semi)
|
Congratulations ! :) I commented the errors in review. |
|
Is it possible that the getCurrentRoutes() function isn't available? When logging this.props I don't see the function |
|
Make sure you are using the version on github and not version 0.11.1. This update was not released yet to npm. |
Added getCurrentRoutes functionality without the need of ref.
Since some projects cannot add ref to the router they cannot access this.refs.navigator.getCurrentRoutes(), hence, they cannot execute getCurrentRoutes.