Replace Deprecated BackAndroid with BackHandler #174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you for your contribution!
Has this been tested to work corretly?
On Fri, 31 May 2019 at 18:15, Juliette Rapala ***@***.***> wrote:
BackAndroid is deprecated and was completely removed from React Native
0.58.0+
This PR replaces all instances of BackAndroid with BackHandler
------------------------------
You can view, comment on, or merge this pull request online at:
#174
Commit Summary
- Replace BackAndroid with BackHandler
File Changes
- *M* components/NavBarContainer.js
<https://github.com/react-native-simple-router-community/react-native-simple-router/pull/174/files#diff-0>
(6)
Patch Links:
-
https://github.com/react-native-simple-router-community/react-native-simple-router/pull/174.patch
-
https://github.com/react-native-simple-router-community/react-native-simple-router/pull/174.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#174?email_source=notifications&email_token=AABWGAX5GX7VYGK4OPLOSDDPYFFI5A5CNFSM4HR4DK2KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GW72FAQ>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABWGATVJF2ZCNZPIJ3UIBTPYFFI5ANCNFSM4HR4DK2A>
.
--
Sent in a hurry from my iPhone.
Sorry for tEh typos!
+31643998429
|
davidLeonardi
approved these changes
May 31, 2019
|
@charpeni are you still on this? |
|
Kinda funny how this bounced back from the big digital void. |
|
Thank you for your contribution @jrapala! Hey @davidLeonardi, I'm still around, but this library as not been maintained since a few months/years? Honestly, I'm a bit impressed that it's still working and being used!? |
|
Guess it’s a testament to the fact that we did a good job back in the days lol |
|
@charpeni do you have a machine around to make a npm release? |
|
No rush @davidLeonardi, I already have it patched in the project I'm using this in. Submitted a PR should anyone else still be using this. Hey, it's simple and it works! 🙂 |
|
Hey again. Will this be released? |
|
Let me do so now
On Thu, 20 Jun 2019 at 17:43, Juliette Rapala ***@***.***> wrote:
Hey again. Will this be released?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#174?email_source=notifications&email_token=AABWGAUA7TGN3JHCRJYWHTLP3OQQNA5CNFSM4HR4DK2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYFZZGI#issuecomment-504077465>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABWGAQ547QNAERWSKT57ZLP3OQQNANCNFSM4HR4DK2A>
.
--
Sent in a hurry from my iPhone.
Sorry for tEh typos!
+31643998429
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BackAndroid is deprecated and was completely removed from React Native 0.58.0+
This PR replaces all instances of BackAndroid with BackHandler