#86 Fix singletone class initialisation

[Romick2005]

Also take care of start stop Observing issue on metro bundler restart/reload/hot-reload.

[zxcpoiu]

@Romick2005

So you do not have init multiple times after this PR?

[Romick2005]

Actually init called multiple times, but initPrivate only ones. Also on multiple call of init the returning result is same initialised only one time object. But generally this PR implements real singletone pattern.

[zxcpoiu]

About startObserving and stopObserving, would you please remove them and treat it as your own workaround in your private branch?

I don't think to ignore stopObserving when debug is a valid solution here.

Reload process has causes similar issues around different libs ( like mis-created multiple instances for react-native-webrtc, IIRC ), given that the reload only happens on DEBUG mode only, and we can not assure that the behavior is a bug or whether it will change in the future or not, not to say there are different algorithms / fallbacks / Engines there ( ex: full reload / HMS Fast Refresh...etc ), I prefer not to add this for general usages. Personally, I only find Fast Refresh useful when I'm tweaking UI stuff, if the test is related to native library, I always did a clean restart ( swipe out ) to prevent any reload-caused issues.

I think the more appropriate way would be needing an event api like onRefresh or onReload for the native side provided by React Native, and user can config them to reset some states.

[zxcpoiu]

1. remove stopObserving workaround for refresh, keep this PR simple and could be discussed in another PR

2. remove unused / commented debugging logs

[zxcpoiu]

above should only change the function name, instead making a mess diff

[zxcpoiu]

@jonastelzio @danjenkins

Hello, would you mind to take a look if this solves your problem described in #85?

[zxcpoiu]

Thanks @Romick2005
I just fix the style to match with the current code base, sorry to push to your branch directly, but I think it's more efficient.
If you want to adjust / fix the style, feel free to send another PR, thanks!

[zxcpoiu]

Since this an open source, so it would be better to follow the current code base's style, and makes minimal changes in a single PR.

But fire a PR to adjust them is acceptable for sure

[Romick2005]

Thank you @zxcpoiu, it's just styling, so never mind. No worries I am ok with this, until it works as expected :).