Skip to content
This repository was archived by the owner on Dec 3, 2022. It is now read-only.

Feature/bob #27

Merged
merged 17 commits into from
Jul 22, 2019
Merged

Feature/bob #27

merged 17 commits into from
Jul 22, 2019

Conversation

slorber
Copy link
Member

@slorber slorber commented Jul 13, 2019

Migrate to a setup using Bob + transpile TS with babel for tests + using types embedded into react-navigation project instead of the type fork of @bySabi

I've already released 1.0.2-alpha.0 already which use the code of this PR, so that people complaining about the missing types can test this release asap.

@satya164 could you give a review please?

Or I'll merge if people are not complaining about the new publish later this week

@slorber slorber requested review from satya164 and ericvicenti July 13, 2019 14:50
This was referenced Jul 13, 2019
@slorber
Copy link
Member Author

slorber commented Jul 13, 2019

Ok so it seems to work now, upgraded React 16.7 alpha to 16.8 and some other deps and now tests are passing 👍

@slorber
Copy link
Member Author

slorber commented Jul 13, 2019

BTW I wrongly published 1.0.0 non alpha the other day, and now even if I marked the releases as deprecated and non functional, people doing yarn add react-navigation-hooks get the bad release instead of the new alpha I published which works.

I tried

npm unpublish [email protected]
npm unpublish [email protected]

It does not fail but does not seem to unpublish anything.

@ericvicenti maybe if you try you'd be more lucky?

Otherwise I guess I will have to publish an official non-alpha soon, because I don't like that users get by default a non-working dependency...

package.json Outdated
[
"commonjs",
{
"flow": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't do anything if you don't use Flow

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks will remove it :)

@CallMeLaNN
Copy link

Can we have this merged? @ericvicenti

@slorber
Copy link
Member Author

slorber commented Jul 22, 2019

Hi @CallMeLaNN . I'll merge this as Satya already took a look and I did changes according to his comment.

But keep in mind you can already use 1.0.2-alpha.0 which includes those PR changes so I don't see why it's very important for you to get this pr merged ;)

@slorber slorber merged commit d766f74 into master Jul 22, 2019
@CallMeLaNN
Copy link

I see, ok.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants