-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
Ok so it seems to work now, upgraded React 16.7 alpha to 16.8 and some other deps and now tests are passing 👍 |
BTW I wrongly published 1.0.0 non alpha the other day, and now even if I marked the releases as deprecated and non functional, people doing I tried
It does not fail but does not seem to unpublish anything. @ericvicenti maybe if you try you'd be more lucky? Otherwise I guess I will have to publish an official non-alpha soon, because I don't like that users get by default a non-working dependency... |
package.json
Outdated
[ | ||
"commonjs", | ||
{ | ||
"flow": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't do anything if you don't use Flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks will remove it :)
Can we have this merged? @ericvicenti |
Hi @CallMeLaNN . I'll merge this as Satya already took a look and I did changes according to his comment. But keep in mind you can already use |
I see, ok. |
Migrate to a setup using Bob + transpile TS with babel for tests + using types embedded into react-navigation project instead of the type fork of @bySabi
I've already released
1.0.2-alpha.0
already which use the code of this PR, so that people complaining about the missing types can test this release asap.@satya164 could you give a review please?
Or I'll merge if people are not complaining about the new publish later this week