Skip to content

Make SubscriberProbe and SubscriberPuppet visible from outside the org.reactivestreams.tck package #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

mathieuancelin
Copy link

Hi,

I may be wrong, but if we need to implement SubscriberVerification to pass the reactive-streams TCK, we need to implements SubscriberProbe and SubscriberPuppet.

Unfortunately those two interfaces are not visible from outside the 'org.reactivestreams.tck' package.

This pull request just make SubscriberProbe and SubscriberPuppet public.

@ktoso
Copy link
Contributor

ktoso commented Apr 23, 2014

Thanks a lot for the interest and PR!
You're definitely right on making those public.

This has been already somewhat addressed in #27 which is sitting around waiting for someone to click merge (it includes making those public, as well as a few other things like that) :-)

// cc @rkuhn, @patriknw

@mathieuancelin
Copy link
Author

Ok, cool !

I hope it's going to be merged soon, it feels weird having my tests located in the 'org.reactivestreams.tck' package :-)

@rkuhn
Copy link
Member

rkuhn commented Apr 24, 2014

I merged #27, so this can be closed now. Thanks for bringing this up in any case!

@rkuhn rkuhn closed this Apr 24, 2014
@mathieuancelin
Copy link
Author

Cool, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants