Skip to content

Ability to provide own react.js version? #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Scratch-net opened this issue Apr 8, 2015 · 2 comments
Closed

Ability to provide own react.js version? #113

Scratch-net opened this issue Apr 8, 2015 · 2 comments
Labels
Enhancement
Milestone
1.5

Comments

@Scratch-net
Copy link

Hi there. 0.13 is out and 0.14 is approaching. Is it possible that we didn't have to wait for a next react.NET release and provide .js by ourselves?
@Daniel15 Daniel15 added this to the 1.5 milestone Apr 12, 2015
@Daniel15
Copy link
Member

I've added this in 27df77f. Ensure you load a version of React in a script (eg. Webpack bundle) via AddScriptWithoutTransform and it should work fine. The only issue I can think of is if React's API changes between versions, as ReactJS.NET will still be calling the old methods internally (eg. React.renderComponent changing to React.render in 0.12).

@Scratch-net
Copy link
Author

Thanks a lot, no need to fork any more!

Daniel15 added a commit that referenced this issue Apr 12, 2015
@Daniel15
Unit test for referencing custom React version. References #113
3ddc128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@Daniel15 @Scratch-net