React.Router ReactDOM.hydrate with ClientOnly #1140
Comments
|
Yeah that’s an oversight. Can you PR a fix?
…On Fri, Jul 17, 2020 at 04:11, JensMeire ***@***.***> wrote:
Thanks for filing a bug! To save time, if you're having trouble using the
library, please check off the items you have tried. If you are just asking
a question, skip right to the bottom.
Please verify these steps before filing an issue, and check them off as
you go
- The relevant native JavascriptEngineSwitcher library packages are
installed (such as JavaScriptEngineSwitcher.V8.Native.win-x64)
- [ x ] The VC++ 2017 runtime is installed
- [ x ] The value of SetUseReact and SetUseBabel is correct in
ReactConfig.cs or Startup.cs
- [ x ] I've looked at the sample projects in this repo to verify that
my app is configured correctly
I'm using these library versions:
- ReactJS.NET: 5.2.4
- JavaScriptEngineSwitcher: 3.5.1
- react and react-dom: (N/A if using bundled react, or version number)
- webpack: (N/A if using bundled react)
- node: (N/A if using bundled react)
Runtime environment:
- OS: Windows 10
- .NET Framework or .NET Core Version: .NET Framework
Steps to reproduce
------------------------------
Hello :)
I was running into following error Prop 'className' did not match.
Server: "MenuItemWrapper SelectedMenuItem" Client: "MenuItemWrapper" and
I stumbled on #521 <#521> .
I'm using the React.Router package and my project uses a URL query
parameter to define a default selected menuitem.
I saw in PR#541
<https://github.com/reactjs/React.NET/pull/541/files#diff-86e62cbc596a87b1526b6b60ffce4a63>
ReactComponent checks on clientOnly but this is not the case for
ReactRouterComponent
<https://github.com/reactjs/React.NET/blob/master/src/React.Router/ReactRouterComponent.cs#L105>
.
Is this intentional? if so, why?
Thanks in advance!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1140>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHGCFXDY4374PZSXERF6ADR4AWVHANCNFSM4O6CBQOA>
.
|
|
@dustinsoftware Sure :) |
dustinsoftware
added a commit
that referenced
this issue
Jul 22, 2020
* Added UseServerSideRendering and ClientOnly check to ReactRouterComponent * Small changes * Use auto-property for ClientOnly Co-authored-by: Dustin Masters <[email protected]>
|
Released :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Thanks for filing a bug! To save time, if you're having trouble using the library, please check off the items you have tried. If you are just asking a question, skip right to the bottom.
Please verify these steps before filing an issue, and check them off as you go
JavaScriptEngineSwitcher.V8.Native.win-x64)SetUseReactandSetUseBabelis correct inReactConfig.csorStartup.csI'm using these library versions:
ReactJS.NET: 5.2.4JavaScriptEngineSwitcher: 3.5.1reactandreact-dom: (N/A if using bundled react, or version number)webpack: (N/A if using bundled react)node: (N/A if using bundled react)Runtime environment:
Steps to reproduce
Hello :)
I was running into following error
Prop 'className' did not match. Server: "MenuItemWrapper SelectedMenuItem" Client: "MenuItemWrapper"and I stumbled on #521 .I'm using the React.Router package and my project uses a URL query parameter to define a default selected menuitem.
I saw in PR#541 ReactComponent checks on clientOnly but this is not the case for ReactRouterComponent.
Is this intentional? if so, why?
Thanks in advance!
The text was updated successfully, but these errors were encountered: