Skip to content

gulpfile.js and files from Resources folder in 2.2.0 #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vkrol opened this issue Feb 10, 2016 · 5 comments
Closed

gulpfile.js and files from Resources folder in 2.2.0 #222

vkrol opened this issue Feb 10, 2016 · 5 comments

Comments

@vkrol
Copy link

vkrol commented Feb 10, 2016

Hello.

When I install React.Core package from NuGet, the gulpfile.js and files from Resources folder have been added to the my project. Why is this happening? Do I need really these files? I cannot find anything about it in the documentation.

Thanks!

@WirthAware
Copy link

As far as i understand it correctly you can now tell reactjs.net to load your own reactjs version.
If you still want to use the React version from react.js.net you don't need these files.
If you want to use reactjs from e.g. npm this will help you to bundle the reactjs version.
These files are just helper starting points to do so.
And you have to tell your ReactConfig that you are loading reactjs by ding:

        ReactSiteConfiguration.Configuration
            .SetLoadReact(false)

@Daniel15
Copy link
Member

Hmm, that's not supposed to happen! You don't need those files at all, they're only used internally in ReactJS.NET. What version of Visual Studio are you using, and what version of ASP.NET?

Sorry for the delay in replying, I was on vacation.

@sfadeev
Copy link

sfadeev commented Feb 14, 2016

These files comes from folder content from React.Core.2.2.0.nupkg, this is the expected behavior for content files - Nuget include content of content folder to project while installing packages.

If these files are completely not required in end projects using React.Net (I've checked, seems works fine without them) they should be excluded from .nupkg. Simple way to do so is to mark these files with Build Action None in project React.Core (right now files marked with Build Action Content).

@Daniel15
Copy link
Member

Oh yeah, that sounds like a mistake. I'll fix this up soon. Thanks :)

Sent from my phone.
On Feb 14, 2016 6:22 AM, "Sergey Fadeev" [email protected] wrote:

These files comes from folder content from React.Core.2.2.0.nupkg, this
is the expected behavior for content files - Nuget include content of
content folder to project while installing packages.

If these files are completely not required in end projects using React.Net
(I've checked, seems works fine without them) they should be excluded from
.nupkg. Simple way to do so is to mark these files with Build Action None
in project React.Core (right now files marked with Build Action Content).


Reply to this email directly or view it on GitHub
#222 (comment).

@Daniel15
Copy link
Member

Just released ReactJS.NET 2.2.1 which fixes this. Thanks for the bug report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants