Skip to content

Fix link to development NuGet feed #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dustinsoftware opened this issue Jun 5, 2019 · 7 comments
Open

Fix link to development NuGet feed #825

dustinsoftware opened this issue Jun 5, 2019 · 7 comments

Comments

@dustinsoftware
Copy link
Member

As a part of consolidating the CI services in #791 to use just Azure Pipelines, I missed that we are still linking to the Appveyor package server. This issue discusses bringing that functionality back.

A few possibilities

  • Publish alpha packages automatically to the main nuget feed any time there is a version bump in build.proj
  • Push nuget packages to appveyor's nuget feed via a custom build step from azure pipelines (docs)
  • Write some custom scripts to work around the msbuild issues in Appveyor
@dustinsoftware dustinsoftware changed the title Fix link to development packages Fix link to development NuGet feed Jun 5, 2019
@dustinsoftware
Copy link
Member Author

I managed to get package publishing working from Azure pipelines, although it is still a manual process to promote a build. That way several commits can land into master without resulting in a package publish for each CI build.

Under Azure Pipelines > Releases, click Create Release and pick the build to be published. We still need to bump the major/minor/patch parts of the version in build.proj before creating a release. I'd like to see if Azure pipelines can detect the change in version number and automatically publish a new release, which would remove an extra step...

Eg a bump from 5.0.0-alpha5 to 5.0.0-alpha6 should automatically publish a new package.

@Daniel15
Copy link
Member

Daniel15 commented Jun 9, 2019

Really cool, thanks for looking into it 😄

@dustinsoftware
Copy link
Member Author

Planning on moving to the Github package registry, but ran into a few blockers:

  • Package publishing appears to be rate limited. Trying to use the nuget CLI to push all packages only results in the first few succeeding. Not sure how to get past this one without putting a sleep in the build, waiting to hear back from support on this one
  • My personal access token allows pushing packages to my fork, but not the reactjs repo. This is a problem because the package source is specified at build time via the projectUrl or repository element in the generated nuspec from the build. We will likely need to just wait for the beta to be more widely opened.

The Azure pipelines deploy is here and is all ready to go once the blockers are resolved.

@Daniel15
Copy link
Member

Daniel15 commented Jun 23, 2019 via email

@dustinsoftware
Copy link
Member Author

Yep, I sent them a support email about five minutes ago :) will see what they say

@Daniel15
Copy link
Member

Did you hear back from GitHub about the rate limiting?

@dustinsoftware
Copy link
Member Author

dustinsoftware commented Jul 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants