Add HtmlHelperExtension flag to turn off server side rendering #103
Conversation
…erver-side render stage while still outputing client-side code. Useful for debugging and quicker dev cycles
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks! |
|
Hah. I just realized that PR #49 was for the same idea. Well, this is a simple implementation, no copy paste code, it has tests, and it works :) Let me know if you will accept it and I will sign the CLA. |
| { | ||
| Props = new { hello = "World" } | ||
| }; | ||
| var result = component.RenderHtml(true); //renderContainerOnly = true |
There was a problem hiding this comment.
Use named arguments for boolean parameters. component.renderHtml(renderContainerOnly: true)
|
Thanks, this looks pretty good! Please sign the CLA and fix the very minor comments and I'll be happy to merge this :) |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
…lean param in test case
|
@Daniel15 alright! I addressed the two comments that I could and signed the CLA. Let me know if you need anything else. |
Add HtmlHelperExtension flag to turn off server side rendering
|
Thanks! |
I often find myself wanting/needing to disabled server-side rendering during development in order to use the Chrome debugger for troubleshooting javascript syntax issues and various React bugs/errors. My current process is to manually write out the client-side initialization code and commenting out the server-side helper:
This PR adds a flag that let's us instruct ReactJS.NET to simply render the client-side initialization code which can easily be turned off (back to server-side + client-side mode) when done debugging/developing.
If you don't think this is appropriate or would prefer it be implemented differently, just let me know.
jslatts