Skip to content

Upgrade to aspnet5 beta5 version #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 16, 2015
Merged

Upgrade to aspnet5 beta5 version #147

merged 3 commits into from
Jul 16, 2015

Conversation

xabikos
Copy link
Contributor

@xabikos xabikos commented Jul 16, 2015

Include the required changes to use the latest, beta 5, version of asp.net 5

{
return _physicalFileSystem.Watch(filter);
}
#endif

private class JsxFileInfo : IFileInfo
private class JsxFileInfo : IFileInfo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert this change please, it's just changing tabs to spaces. Please keep it as tabs.

@Daniel15
Copy link
Member

This looks pretty good, please use tabs rather than spaces for indentation though. Once you change that, I'll merge this.

@xabikos
Copy link
Contributor Author

xabikos commented Jul 16, 2015

Thanks for the quick respond. I made the changes and it should be fine. Any plans for a new release?

@Daniel15
Copy link
Member

There's still spaces around, but I can fix them separately. I'll try to push a new release soon - In the meantime you can run the dev build (dev-build.bat) and use the NuGet packages it builds.

Daniel15 added a commit that referenced this pull request Jul 16, 2015
Upgrade to aspnet5 beta5 version
@Daniel15 Daniel15 merged commit 5675836 into reactjs:master Jul 16, 2015
@xabikos xabikos deleted the aspnet5beta5 branch July 16, 2015 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants