ContainerClass #211
Merged
ContainerClass #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| else | ||
| { | ||
| return string.Format( | ||
| "<{2} id=\"{0}\" class=\"{3}\">{1}</{2}>", |
There was a problem hiding this comment.
Rather than having two separate branches here, it might be worth having a list of attributes
Something like (not tested):
var attributes = id=\"" + ContainerId + "\";
if (!string.IsNullOrEmpty(ContainerClass))) {
attributes += " class=\"" + ContainerClass + "\"";
}
return string.Format(
"<{2} {0}>{1}</{2}>",
attributes,
html,
ContainerTag
);
|
@jovnas updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
|
Thanks! This looks reasonable to me. Could you please squash your commits, and then I'll merge this :) |
Add possibility to add class to container tag.
|
I think I got it right... Haven't really used git before. :-) |
|
Thanks! |
|
This is now available in ReactJS.NET 2.2. Thanks for your contribution! |
|
Nice! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add possibility to add class to container tag.