-
Notifications
You must be signed in to change notification settings - Fork 926
Allow Javascript engines to be bypassed entirely. #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I see that I forgot to sign the CLA before submitting this PR - just did that. |
Seems reasonable to me! It looks like there's a number of "invisible" changes that aren't actually related to this diff (looks like it might be changing the line endings from |
#if LEGACYASPNET | ||
namespace React.Web.Mvc | ||
namespace React.Web.Mvc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see any noticeable change in this line so it's probably replaced newlines (\r\n
with \n
or vice versa). Could you please revert all the lines that aren't directly related to your change?
709d7c3
to
14dce95
Compare
Yeah, it looks like the line endings are mixed in some of the files and VS auto corrected them :) Fix pushed |
It looks like a unit test is failing. Can you please take a look? https://ci.appveyor.com/project/Daniel15/react-net/build/108
You can run the |
14dce95
to
c6d7559
Compare
Fixed, sorry about that. I had been using the sample site to test before, but forgot to build solution before I pushed. |
If no server-side rendering will occur on a page, for instance if component render is called with clientOnly: true, it is pointless to initialize a Javascript engine on the server. This allows the consumer to easily disable all server side Javascript if the server is under heavy load.
c6d7559
to
e931f4e
Compare
Thanks 😄 |
@Daniel15 would you mind publishing a package update so I can consume these changes? |
Will try to do that soon :) In the meantime, you could use the latest development package (see http://reactjs.net/getting-started/download.html#development-builds) |
This has been included in the 2.4 release (http://reactjs.net/2016/05/2.4.0-release.html). Thanks for your contribution! |
If no server-side rendering will occur on a page, for instance if
component render is called with clientOnly: true, it is
pointless to initialize a Javascript engine on the server. This allows the
consumer to easily disable all server side Javascript if the server is
under heavy load.