Making React.AspNet compatible with ASP.NET Core RC2 #271

ShikiGami · 2016-05-21T04:37:01Z

Changes the names of assemblies from ASP.NET 5 RC1 to ASP.NET Core RC2
Changes to the new structure of project.json and xproj
All old DNX commands were replaced by the new dotnet cli.
IApplicationEnvironment was deprecated, and all its information was reallocated to IHostingEnvironment .
StaticFileMiddleware now requires an IOption<StaticFileOptions> instead of a plain StaticFileOptions.
IHttpContextAccessor isn't set any longer by default. Since we don't need HttpContext.RequestServices in order to get the PerRequestRegistrations service, and we can get it directly from IApplicationBuilder.ApplicationServices, I just deleted solving the service all together.

Fix issue #268 and #269

* It's able to build using dev-build * It's able to run IIS Express * It fails at runtime, React.AspNet cannot resolve React.Core dependency on runtime. * The output folder for React.AspNet has become more messy, not sure if this is something that can be solved * It is not creating the nupkg for React.AspNet

…ate nuget packages.

Daniel15 · 2016-05-22T08:13:31Z

appveyor.yml

@@ -2,8 +2,6 @@ version: '{build}'
 os: Visual Studio 2015
 install:
 - set PATH=%ProgramFiles(x86)%\MSBuild\14.0\Bin;%PATH%
- dnvm update-self
- dnvm install 1.0.0-rc1-update1


Should this run the equivalent dotnet command to ensure RC2 is installed on the build machine?

As far as I know it no longer works that way in RC2. There is no equivalent to dnvm in the new toolset. If you have .NET Core RC2 installed already, you can just get the ASP.NET Core packages using NuGet.
That was one of the biggest changes from RC1 to RC2, and it was done in order to make all .NET Core environments consistent with each other.

Thanks for the info 👍

Looks like they've got an install script for CI servers (see https://dotnet.github.io/docs/core-concepts/dnx-migration.html). However, their docs for AppVeyor just say "TODO" (https://dotnet.github.io/docs/core-concepts/core-sdk/cli/using-ci-with-cli.html). It's fine to ignore that for now if the AppVeyor build actually works with no changes.

Daniel15 · 2016-05-22T08:23:02Z

Thanks so much for working on this! Just a few small comments. Please use tabs rather than spaces in .cs files 😄

Please leave a comment once you update the pull request, unfortunately Github doesn't send notifications for updates to pull requests.

* Reverted unnecesary white space * Deleted unnecesary comment * Added missing copyright notice * Fixed indentation * Changed target of local dependencies to project * Reverted React.AspNet's old GUID * Deleted React.AspNet's AssemblyInfo.cs * Changing ASPNET5 preprosesor directive name to ASPNETCORE * Fixed project.json so that the NuGet package would show the correct info * Fixed dotnet pack script so that it doesn't create empty packages

ShikiGami · 2016-05-22T10:59:54Z

Just committed the fixes you asked for.
I also realized that dotnet pack was creating empty packages because apparently it cannot read the .xproj and therefore it doesn't know where is the proper outpath for the project's binaries and objects, so I also fixed the script and confirmed it was creating the proper packages.

Daniel15 · 2016-05-22T23:46:57Z

src/React.AspNet/project.json

-    "MsieJavaScriptEngine": "1.7.0"
+    "MsieJavaScriptEngine": "1.7.0",
+    "React.Core": {
+      "target": "project"


Oh cool, I didn't know about being able to target projects like this! Is there documentation on it?

Daniel15 · 2016-05-22T23:48:24Z

Thank you so much, this is a fantastic pull request. I've got a few of my own projects to upgrade from RC1 to RC2, and this PR is a good example that I can follow for the other projects 😄

Daniel15 · 2016-05-23T10:55:56Z

Hey @ShikiGami, I'm having trouble building this on my computer:

  Errors in C:\src\ReactJS.NET\src\React.AspNet\React.AspNet.xproj
      React.AspNet 2.3.0 is not compatible with .NETFramework,Version=v4.5.1.
      Some packages are not compatible with .NETFramework,Version=v4.5.1.

However, I see that it's working fine on AppVeyor, so I guess it should be working. Any ideas?

ShikiGami · 2016-05-23T12:03:38Z

Some packages are not compatible with .NETFramework,Version=v4.5.1.

It isn't telling you which packages aren't compatible?

wassim-azi · 2016-05-23T14:34:55Z

@Daniel15 Does it work on your computer ?
When will this PR be merged ?

Daniel15 · 2016-05-24T02:10:40Z

Strangely I can't replicate that issue any more. ¯_(ツ)_/¯

@wassim-azirar - It's already been merged, you can use the packages from the development server if you like (details at http://reactjs.net/getting-started/download.html#development-builds)

wassim-azi · 2016-05-24T08:35:58Z

I followed the instructions but I'm still having the same error :(

ShikiGami · 2016-05-24T08:40:16Z

@wassim-azirar
It isn't compatible with .NETCoreApp, you need to use the full .NET Framework for it.
In frameworks replace netcoreapp1.0 with net451

Daniel15 · 2016-05-24T10:44:28Z

Yeah, not all dependencies are available for .NET Core (eg. currently there's no JS engine that runs on .NET Core) so you need to use the full .NET Framework.

Daniel15 · 2016-05-24T11:47:06Z

src/React.AspNet/HttpContextLifetimeProvider.cs

-					);
-				}
-				var registrations = requestServices.GetService<PerRequestRegistrations>();
+				var registrations = _appServiceProvider.GetService<PerRequestRegistrations>();


This change was incorrect, it wasn't handling per-request singletons properly and was instead just using a single instance for the entire app. I fixed it in a4992da 👍

Daniel15 · 2016-05-27T08:13:38Z

This has been included in the 2.4 release (http://reactjs.net/2016/05/2.4.0-release.html). Thanks for your contribution!

pauldotknopf · 2016-06-06T06:38:00Z

I updated VroomJs to support .NET Core.

https://github.com/pauldotknopf/vroomjs-core

Daniel15 · 2016-06-23T06:30:37Z

@pauldotknopf - That's great news! I should probably update JsPool to have a .NET Core build, then we should be able to get ReactJS.NET running on .NET Core :)

ShikiGami added 5 commits May 20, 2016 13:29

Replaced xproj with csproj for React.AspNet

aa17057

Fixed to run at runtime.

b566a5a

Restored React.AspNet's xproj, and used a postcompile script to gener…

fa05d2e

…ate nuget packages.

Remove DNVM references

e887678

Daniel15 reviewed May 22, 2016
View reviewed changes

Daniel15 merged commit fe6f54f into reactjs:master May 22, 2016

Daniel15 reviewed May 24, 2016
View reviewed changes

Daniel15 mentioned this pull request May 26, 2016

React.AspNet is not working with ASP.NET Core 1.0 RC2 #268

Closed

facebook-github-bot added the GH Review: review-needed label Nov 4, 2016

Making React.AspNet compatible with ASP.NET Core RC2 #271

Making React.AspNet compatible with ASP.NET Core RC2 #271

Uh oh!

Conversation

ShikiGami commented May 21, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel15 May 22, 2016

Choose a reason for hiding this comment

Uh oh!

ShikiGami May 22, 2016

Choose a reason for hiding this comment

Uh oh!

Daniel15 May 22, 2016

Choose a reason for hiding this comment

Uh oh!

Daniel15 May 22, 2016

Choose a reason for hiding this comment

Uh oh!

Daniel15 commented May 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShikiGami commented May 22, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Daniel15 May 22, 2016

Choose a reason for hiding this comment

Uh oh!

Daniel15 commented May 22, 2016

Uh oh!

Daniel15 commented May 23, 2016

Uh oh!

ShikiGami commented May 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wassim-azi commented May 23, 2016

Uh oh!

Daniel15 commented May 24, 2016

Uh oh!

wassim-azi commented May 24, 2016

Uh oh!

ShikiGami commented May 24, 2016

Uh oh!

Daniel15 commented May 24, 2016

Uh oh!

Daniel15 May 24, 2016

Choose a reason for hiding this comment

Uh oh!

Daniel15 commented May 27, 2016

Uh oh!

pauldotknopf commented Jun 6, 2016

Uh oh!

Daniel15 commented Jun 23, 2016

Uh oh!

Uh oh!

ShikiGami commented May 21, 2016 •

edited

Loading

Daniel15 commented May 22, 2016 •

edited

Loading

ShikiGami commented May 22, 2016 •

edited

Loading

ShikiGami commented May 23, 2016 •

edited

Loading