Skip to content

Possible fix for IIS crash described in issue #28 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Possible fix for IIS crash described in issue #28 #33

wants to merge 2 commits into from

Conversation

jlchmura
Copy link
Contributor

This may be a possible fix for issue #28. We've deployed it across our development machines as so far, no one has experienced the access violation.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Daniel15
Copy link
Member

This is really interesting. The IoC container should be disposing things at the end of the request: https://github.com/reactjs/React.NET/blob/master/src/React.Web/TinyIoCAspNetExtensions.cs#L66

Can you confirm whether that DisposeAll method is being called properly? It should be disposing the environment. Maybe just adding IDisposable to the interface would solve it.

@jlchmura jlchmura closed this Aug 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants