Add possibility to set own JsonSerializerSettings in configuration #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This affects how components are rendered server-side.
| /// <summary> | ||
| /// Gets the global site configuration. | ||
| /// </summary> | ||
| IReactSiteConfiguration Configuration { get; } |
There was a problem hiding this comment.
This isn't necessary; the IReactSiteConfiguration and IReactEnvironment are two separate registrations in the IoC container. Please remove it.
Daniel15
added a commit
that referenced
this pull request
Nov 7, 2014
Add possibility to set own JsonSerializerSettings in configuration
|
Thanks! Normally the build server would pick this up and I'd suggest using the latest dev builds (it builds master and uploads to a custom package repository), but something's broken in TeamCity at the moment so the development packages aren't being built at the moment :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to pass own settings to be used for server-side rendering, for example the same you've got in your ASP.NET configuration: