Skip to content

Native IHtmlContent/IHtmlString implementation #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2018
Merged

Native IHtmlContent/IHtmlString implementation #527

merged 1 commit into from
Apr 12, 2018

Conversation

DaniilSokolyuk
Copy link
Contributor

@DaniilSokolyuk DaniilSokolyuk commented Apr 8, 2018 •
edited
Loading

Native IHtmlContent/IHtmlString implementation

Daniel15
Daniel15 reviewed Apr 8, 2018
View reviewed changes
Copy link
Member

@Daniel15 Daniel15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any numbers for how much of a perf boost this particular change provides?

@DaniilSokolyuk
Copy link
Contributor Author

This is extension part of this PR and will not give extra perf, but this part is needed to simplify the code and prepare this part for TextWriter for reduce a lot of allocations and LOH hitting

dustinsoftware
dustinsoftware approved these changes Apr 12, 2018
View reviewed changes
Copy link
Member

@dustinsoftware dustinsoftware left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, going to do a bit of local testing before I merge this (really wish we had full integration tests instead of just unit tests...)

@dustinsoftware
Copy link
Member

Tested on React.Sample.Mvc4 and React.Sample.Router.CoreMvc ✅

@dustinsoftware dustinsoftware merged commit cb086eb into reactjs:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Daniel15 Daniel15 Daniel15 left review comments

@dustinsoftware dustinsoftware dustinsoftware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DaniilSokolyuk @dustinsoftware @Daniel15