Skip to content

JsxTransformer exception now includes whole inner exception, not only message #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

mandrek44
Copy link
Contributor

JsxTransformer adds the file name to exception message, however it discards the inner exception details, like stack trace. By including the inner exception in the thrown exception object we don't loose any information.

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at [email protected]. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@Daniel15
Copy link
Member

It looks like you've accidentally sent this pull request from your master branch rather than just the branch with this change, so it's also pulled in the whole OWIN pull request (#69). I'll review it once you update the pull request with the correct branch :)

@mandrek44
Copy link
Contributor Author

I created new Pull Request: #70

@mandrek44 mandrek44 closed this Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants