Skip to content

Translate Code Splitting #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 20, 2019
Merged

Conversation

GasimGasimzada
Copy link
Collaborator

@GasimGasimzada GasimGasimzada commented Feb 14, 2019

  • Bundling
  • Code Splitting
  • Route based splitting
  • Named Exports

@GasimGasimzada GasimGasimzada changed the title WIP: Translate Code Splitting Translate Code Splitting Feb 14, 2019
@tesseralis tesseralis requested a review from Haqverdi February 18, 2019 03:22
@tesseralis
Copy link
Member

@Haqverdi are you ready to merge this in? It doesn't seem like there are a lot of you so it might not be a good idea to have two reviewers per page.

@Haqverdi
Copy link
Contributor

@Haqverdi are you ready to merge this in? It doesn't seem like there are a lot of you so it might not be a good idea to have two reviewers per page.

Yes, I checked the main parts, everything seems to be okay, unfortunately we are 2-3 people for now, therefore have to do so in order to translate as soon as possible.

@azizaismayilova
Copy link
Collaborator

@tesseralis I have checked the content and there are some issues (typos, grammar issues). I will push them, once they are all fixed.

@Haqverdi
Copy link
Contributor

I think we should translate the main part as soon as possible, then correct the shortcomings

@azizaismayilova azizaismayilova merged commit bef5659 into master Feb 20, 2019
@netlify
Copy link

netlify bot commented Feb 20, 2019

Deploy preview for az-reactjs ready!

Built with commit 54250e5

https://deploy-preview-21--az-reactjs.netlify.com

@GasimGasimzada GasimGasimzada deleted the translate-code-splitting branch February 22, 2019 23:11
@tesseralis tesseralis mentioned this pull request Oct 14, 2019
99 tasks
@GasimGasimzada GasimGasimzada added this to the Advanced Guides milestone Oct 14, 2019
@GasimGasimzada GasimGasimzada added the new page Translate a new page label Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new page Translate a new page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants