Skip to content

updating rendering elements from #21 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 8, 2019

Conversation

saranshkataria
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 7, 2019

Deploy preview for hi-reactjs ready!

Built with commit d94a184

https://deploy-preview-41--hi-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Jul 7, 2019

Deploy preview for hi-reactjs ready!

Built with commit 8f1bf91

https://deploy-preview-41--hi-reactjs.netlify.com

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just a small feedback and I think its good to go from my end


```js
const element = <h1>Hello, world</h1>;
```

Unlike browser DOM elements, React elements are plain objects, and are cheap to create. React DOM takes care of updating the DOM to match the React elements.
ब्राउज़र DOM एलेमेंट्स के विपरीत, React एलेमेंट्स प्लेन ऑब्जेक्ट है और इन्हें बनाना आसान है। React DOM React एलेमेंट्स के अनुसार DOM को अपडेट रखता है।
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

एलेमेंट्स => एलिमेंट्स

Any thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@arshadkazmi42 arshadkazmi42 Jul 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few more you have missed.
I think you should do CTLR+F and Replace All

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@arshadkazmi42 arshadkazmi42 merged commit b1791cb into reactjs:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants