-
Notifications
You must be signed in to change notification settings - Fork 265
Translate Implementation Notes #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Deploy preview for idreactjs ready! Built with commit 0043fa3 |
Deploy preview for id-reactjs ready! Built with commit 0043fa3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tegarjgap! Here are my notes for the first half of the page. Will continue to read through later tonight.
change 'publik API' into 'API publik' Co-Authored-By: Resi Respati <[email protected]>
remove italic symbol on path source Co-Authored-By: Resi Respati <[email protected]>
Change subclasses into Subkelas Co-Authored-By: Resi Respati <[email protected]>
Change ambigous text Co-Authored-By: Resi Respati <[email protected]>
Change Element into Elemen Change misalnya into mis. Co-Authored-By: Resi Respati <[email protected]>
Change element into elemen Co-Authored-By: Resi Respati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank a lot @resir014 , I have reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass. After this is done, everything should look good.
Change module name in React and fix capitalize Co-Authored-By: Resi Respati <[email protected]>
Change subclasses into Subkelas Co-Authored-By: Resi Respati <[email protected]>
Fix ambiguous text Co-Authored-By: Resi Respati <[email protected]>
remove italic for method name in code blocks and fix the grammar Co-Authored-By: Resi Respati <[email protected]>
remove italic for method name in code blocks Co-Authored-By: Resi Respati <[email protected]>
remove italic in method name in code blocks Co-Authored-By: Resi Respati <[email protected]>
remove italic for method name in code blocks Co-Authored-By: Resi Respati <[email protected]>
change contained into dibungkus Co-Authored-By: Resi Respati <[email protected]>
fix capitalize text Co-Authored-By: Resi Respati <[email protected]>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <[email protected]>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <[email protected]>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <[email protected]>
add hypen on text 'dirender' Co-Authored-By: Resi Respati <[email protected]>
don't translate text 'key' Co-Authored-By: Resi Respati <[email protected]>
change sentence 'dari tutorial hidup ini' become 'dari tutorial ini berada' Co-Authored-By: Resi Respati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I already finish all review. thank a lot for correcting me @resir014 , so excited collaborating with you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for your help! 🎉
Alright, Thanks @resir014 |
No description provided.