-
Notifications
You must be signed in to change notification settings - Fork 265
Translate Shallow Renderer #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refer to this discussion once it is added to glossary.
Co-Authored-By: riandy-dimas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's good enough but there's several sentence that can be improved, what do you think? 😄
Deploy preview for idreactjs ready! Built with commit 3efba65 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from me.. Thanks for the contribution @riandy-dimas ! 🎉
@arfianadam @gedeagas any comments?
Deploy preview for id-reactjs ready! Built with commit 3efba65 |
I have done translating this section, kindly review it 🙏