Skip to content

Initial translation of renderToPipeableStream page #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 6, 2023
Merged

Initial translation of renderToPipeableStream page #488

merged 11 commits into from
Jun 6, 2023

Conversation

zaynhakim
Copy link
Contributor

Closes #458

@zaynhakim zaynhakim marked this pull request as ready for review April 29, 2023 03:09
@mhaidarhanif mhaidarhanif requested a review from r17x April 30, 2023 21:49
@github-actions
Copy link

github-actions bot commented Apr 30, 2023 •
edited
Loading

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

mhaidarhanif
mhaidarhanif requested changes Apr 30, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improvement.

mazipan
mazipan reviewed May 1, 2023
View reviewed changes
mazipan
mazipan reviewed May 1, 2023
View reviewed changes
mhaidarhanif
mhaidarhanif reviewed Jun 4, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some improvements and italice most English words.

This is a comment, no request for changes to avoid future blocking.

@mhaidarhanif
Copy link
Collaborator

@zaynhakim Please fix and resolve most issues. So we can merge this soon.

mhaidarhanif
mhaidarhanif requested changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please italice most English words like what I've mentioned. It's not just a few of them, but several of them.

@mhaidarhanif
Copy link
Collaborator

mhaidarhanif commented Jun 5, 2023 •
edited
Loading

Since turns out there are 20+ issues, I've requested the changes and now might block merging before they're resolved.

@zaynhakim
Copy link
Contributor Author

Hi, thanks for the feedback. Going to reread it comprehensively.

@mazipan
Copy link
Collaborator

mazipan commented Jun 6, 2023

Fix the conflict first

@zaynhakim
Copy link
Contributor Author

Done, resolved

@mazipan
Copy link
Collaborator

mazipan commented Jun 6, 2023

@mhaidarhanif help to re-review

mhaidarhanif
mhaidarhanif approved these changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright seems good. Let's merge

@mhaidarhanif mhaidarhanif merged commit cfd8c4d into reactjs:main Jun 6, 2023
@zaynhakim zaynhakim deleted the my-contribs branch October 26, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaidarhanif mhaidarhanif mhaidarhanif approved these changes

@mazipan mazipan mazipan approved these changes

@resir014 resir014 Awaiting requested review from resir014

@zainfathoni zainfathoni Awaiting requested review from zainfathoni

@r17x r17x Awaiting requested review from r17x

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

renderToPipeableStream
3 participants
@zaynhakim @mhaidarhanif @mazipan