Skip to content

docs: translate API Reference -> react -> <StrictMode> #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 24, 2023

Conversation

irvanahmadp
Copy link
Contributor

@irvanahmadp irvanahmadp commented Apr 29, 2023

Closes #415

Description

Translate the StrictMode page.
Page URL: https://id.react.dev/reference/react/StrictMode

Copy link
Contributor

@rendiputra rendiputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some suggestion transleting, cc @irvanahmadp

@irvanahmadp
Copy link
Contributor Author

Add some suggestion transleting, cc @irvanahmadp

Okay, thank you for the suggestion

Copy link
Contributor

@rendiputra rendiputra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to delete the translated paragraph

@irvanahmadp
Copy link
Contributor Author

Forgot to delete the translated paragraph

Updated, thank you for the correction

Copy link
Collaborator

@r17x r17x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • render -> render
  • me-render -> me-render

r17x

This comment was marked as duplicate.

@irvanahmadp
Copy link
Contributor Author

  • render -> render

    • me-render -> me-render

Updated, should I change "dirender" and "rendering" too?

@r17x
Copy link
Collaborator

r17x commented May 23, 2023

@irvanahmadp yes, if you found another just change like that!

Thanks

@irvanahmadp
Copy link
Contributor Author

@irvanahmadp yes, if you found another just change like that!

Thanks

Done, Kindly for the review again @r17x 🙏

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor change. @irvanahmadp

@mazipan
Copy link
Collaborator

mazipan commented May 31, 2023

Help to recheck @resir014 @r17x

@irvanahmadp irvanahmadp requested review from resir014 and r17x June 16, 2023 11:14
@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 changed the title docs: translation of <StrictMode> page docs: translate API Reference -> react -> <StrictMode> Jun 24, 2023
@resir014 resir014 merged commit f08ee59 into reactjs:main Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<StrictMode>
5 participants