docs: translate react-dom -> createRef
#554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
resir014
reviewed
May 10, 2023
There was a problem hiding this comment.
@andriawan, some minor change before we go further into the PR.
andriawan
force-pushed
the
translate-createRef
branch
from
71212c5 to
ec3adfe
Compare
andriawan
force-pushed
the
translate-createRef
branch
from
ec3adfe to
e401131
Compare
andriawan
force-pushed
the
translate-createRef
branch
from
e401131 to
091a062
Compare
andriawan
changed the title
andriawan
force-pushed
the
translate-createRef
branch
from
091a062 to
0c6bc5c
Compare
resir014
requested changes
May 26, 2023
There was a problem hiding this comment.
@andriawan Looks good, there are only a few changes needed before we merge.
andriawan
force-pushed
the
translate-createRef
branch
from
0c6bc5c to
ff524ba
Compare
andriawan
force-pushed
the
translate-createRef
branch
from
ff524ba to
fa142c0
Compare
|
this improvements are ready to review again. cc @resir014 |
resir014
approved these changes
Jun 13, 2023
resir014
changed the title
react-dom -> createRef
FelixFern
pushed a commit
to FelixFern/id.react.dev
that referenced
this pull request
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #551
Description
Translate the
createRefpage.Page URL: https://id.react.dev/reference/react/createRef