Update normalizeClassDefinition.js #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
requested changes
Jun 7, 2018
|
I wrote the test in a way the works in v1. I realized that i've not noticed this before because it seems like bablyon has only recently started making these ClassDeclarations, in the past they were expressions |
danez
approved these changes
Jun 7, 2018
|
Yeah it probably does not happen in v2 but does happen in the v3 beta. But good to have the check anyway. Thank you very much. |
danez
pushed a commit
that referenced
this pull request
Jun 26, 2018
* Update normalizeClassDefinition.js * add test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should i submit this against v3-dev? I meant too originally