[fixed] Remove ReactModal__Body--open class when unmounting Modal #94
Conversation
|
We're experiencing the same issue. |
|
👍 Same here. |
|
+1 |
|
+1 need this |
|
@mzabriskie, hello from a former Provonian! Any word on this? |
|
+1, had to copy the functionality into my own close function because the one in the code itself doesn't work. |
|
+1, had to build a workaround until this is ready |
|
Any updates on this? Seems like a significant bug. |
| @@ -136,6 +136,13 @@ describe('Modal', function () { | |||
| unmountModal(); | |||
| }); | |||
|
|
|||
| it('removes class from body when unmounted without closing', function() { | |||
| modal = renderModal({isOpen: true}); | |||
There was a problem hiding this comment.
You need a var here to prevent this from being an implicit global.
|
@jasonblanchard You'll need to resolve some conflicts, but also there is one little note I added to the spec on your commit. Fix that up and resolve any conflicts, and I'm happy to merge and include in the next release. |
jasonblanchard
force-pushed
the
remove-body-class-unmount
branch
from
12ecf65 to
cb53bca
Compare
|
@claydiffrient I've rebased off master, addressed your line note and verified that the fix still works and that all tests are passing. |
This fixes a bug where if a modal was unmounted without closing first, the
ReactModal__Body--openstays on thebodyelement.This causes issues when, for example, you have a react-router link in a modal that takes you directly to another route handler component. The expected behavior for this is the modal closes and all page state related to the modal having been open is reset.