Skip to content

Use .keep instead of .gitkeep to match Rails itself. #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

Use .keep instead of .gitkeep to match Rails itself. #937

merged 1 commit into from
Oct 3, 2018

Conversation

pupeno
Copy link
Contributor

@pupeno pupeno commented Oct 3, 2018

Also, if someone is not using git, a .gitkeep feels odd, where a .keep seems fine.

@pupeno
Use .keep instead of .gitkeep to match Rails itself.
c2eaebb 
Also, if someone is not using git, a .gitkeep feels odd, where a .keep seems fine.
@BookOfGreg
Copy link
Member

Thanks for the contribution, yep agree on matching Rails on this one. 👍

@BookOfGreg BookOfGreg merged commit 2f032e9 into reactjs:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pupeno @BookOfGreg