Translate Handling Events #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ntban15
commented
Feb 24, 2019
ntban15
commented
- Translate Handling Events page
|
Deploy preview for vi-reactjs-org ready! Built with commit c695dd5 |
|
@ntban15 Please resolve conflict |
|
@nampdn Done |
nampdn
requested changes
Feb 26, 2019
|
Chị @ltmylinh ơi, chị review giúp thêm lần nữa cho PR này nhé. |
+ Update 'warning' + Update MDN doc for Classes
|
Mình vừa update từ 'Cảnh báo' thành 'Lưu ý' và link MDN doc cho Class bằng tiếng Việt. |
nampdn
approved these changes
Feb 28, 2019
95 tasks
|
Sorry mấy đứa, mấy nay chị busy xíu nên giờ mới vô translate tiếp được. |
ltmylinh
reviewed
Mar 2, 2019
|
|
||
| ```js | ||
| <button onClick={(e) => this.deleteRow(id, e)}>Delete Row</button> | ||
| <button onClick={this.deleteRow.bind(this, id)}>Delete Row</button> | ||
| ``` | ||
|
|
||
| The above two lines are equivalent, and use [arrow functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions) and [`Function.prototype.bind`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_objects/Function/bind) respectively. | ||
| Hai dòng code trên là tương đương, và lần lượt sử dụng [hàm rút gọn](https://developer.mozilla.org/vi/docs/Web/JavaScript/Reference/Functions/Arrow_functions) và [`Function.prototype.bind`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_objects/Function/bind). |
There was a problem hiding this comment.
It should be: Hai dòng code trên là tương đương, và lần lượt sử dụng "hàm rút gọn" [arrow function]
There was a problem hiding this comment.
Chỗ này ở trên có đề cập tới hàm rút gọn trước nên mình update ở đó nhé
+ Update title + Add some terms explanation
ltmylinh
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.