Skip to content

Bootstrap basic example contents for 1.0 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jul 8, 2022
Merged

Bootstrap basic example contents for 1.0 #1

merged 8 commits into from
Jul 8, 2022

Conversation

benjaoming
Copy link
Collaborator

No description provided.

@benjaoming benjaoming marked this pull request as draft July 6, 2022 13:37
Copy link

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough 👍

@benjaoming
Copy link
Collaborator Author

@ericholscher thanks for the review!

tl;dr This was a quick draft to open the arena on the main question here: Do we want a "basic" mkdocs example WITH API docs or not? I think it's great to use an example with API docs since it shows the big benefits of having code and documentation live alongside and with the same release lifecycle + reflects the basic sphinx example projects pretty much 1:1.

I understand, though, that there are some strong feelings of why MkDocs should not even support API documentation as a core thing, and that some people just think that we are better off without auto-generated docs. I can find the reference later. Yet, I think that we can make a choice to say that this basic example will anticipate API docs as a basic component.

@ericholscher
Copy link

ericholscher commented Jul 7, 2022

In general we don't focus too much priority on mkdocs. So I wouldn't spend a huge amount of time on it, but making it match our Sphinx example makes sense to me. I don't think we need to get bogged down in philosophical debates.

@benjaoming benjaoming marked this pull request as ready for review July 8, 2022 14:55
Copy link
Collaborator Author

@benjaoming benjaoming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now pretty much where I would see it for a 1.0 -- I never managed to make highlight.js work locally for the mkdocs readthedocs theme, was it was advertised to. Maybe it'll work on Read the Docs 🤷

It's interesting that even for a basic example, I would argue that MkDocs needs extensions. However, on the bright side, there's a lot of those.

@benjaoming benjaoming merged commit ccaebe7 into main Jul 8, 2022
@benjaoming benjaoming deleted the bootstrap branch July 8, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants