Skip to content

Be able to create a redis ring from universal options #3012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

peczenyj
Copy link
Contributor

@peczenyj peczenyj commented Jun 2, 2024

Today we can't create a ring in universal ctor / universal options

There is a clash of Addrs field name, that is a slice of strings for all flavors of redis universal client and the ring, that uses a map[string]string

not anymore, using AddressMap field we can create a Ring will full colors :)

this is a cleaning of previous PR #2727 2727

@peczenyj peczenyj changed the title create a ring from universal options Be able to create a redis ring from universal options Dec 3, 2024
@ndyakov
Copy link
Member

ndyakov commented Mar 19, 2025

@peczenyj thank you for the contribution. I would argue Ring is a specific client type implemented by the library and not universally supported. Also, adding AddressMap and having Addrs fields together make the usage of UniversalClient more confusing. I do think that Ring should be separate from the cluster and standalone clients (e.g. UniversalClient)

@ndyakov ndyakov closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants