Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue when a
0
ttl is provided. 0 ttl should mean that the item effectively won't be stored because it's so short-lived. However, the current code fails to pass the 0 ttl to redis, meaning the value is stored forever.This fixes it. I changed the value in some tests from 1 to 0, as it prevents this bug from reappearing, and I believe the number 0 covers the code just as well as number 1.
btw. it would be nice to have prettier / editorconfig or something like that in place, my ide reformatted the code in a bad way on my first attempt to make changes
Checklist
npm test
pass with this change (including linting)?