Skip to content

integration test timing issues #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 7, 2023
Merged

integration test timing issues #306

merged 5 commits into from
Feb 7, 2023

Conversation

slorello89
Copy link
Member

No description provided.

@slorello89 slorello89 changed the title unit test timing issues integration test timing issues Feb 7, 2023
@slorello89
Copy link
Member Author

Had to resolve a couple of timing based issues with the integration tests for Redis OM. Two primary problems

1: In a previous PR I fixed an issue where if a script was reloaded properly, the mock sha that we use for our unit tests was wrong, it appears that I missed a couple of them
2: The timing from #206 was slightly off - yes the "we started out with 5000 ms timeout, delayed a second so we should have less than a 4000 ms timeout" logic seems sound, but Task.Delay only guarantees accuracy to the resolution of the system clock, so it was a few millisecond off, I added some extra buffer so hopefully that shouldn't be an issue anymore

I've run the tests 10 times without a failure (was failing at least 1 / 3 times before) so hopefully this fixes it 🤞

Copy link

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slorello89 slorello89 merged commit 2b9330f into main Feb 7, 2023
@slorello89 slorello89 deleted the fixing-unit-tests branch February 7, 2023 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants