Async for bulk operation #338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed type casting issue for #286
Update RedisObjectHandler.cs
slorello89
reviewed
Mar 28, 2023
slorello89
requested changes
Mar 29, 2023
| @@ -676,12 +676,12 @@ public async Task<List<string>> Insert(IEnumerable<T> items) | |||
| } | |||
|
|
|||
| /// <inheritdoc/> | |||
| public async Task<List<string>> Insert(IEnumerable<T> items, TimeSpan timeSpan) | |||
| public async Task InsertAsync(IEnumerable<T> items, TimeSpan timeSpan) | |||
There was a problem hiding this comment.
Suggested change
| public async Task InsertAsync(IEnumerable<T> items, TimeSpan timeSpan) | |
| public async Task<List<string>> InsertAsync(IEnumerable<T> items, TimeSpan timeSpan) |
| { | ||
| var distinct = items.Distinct().ToArray(); | ||
| if (!distinct.Any()) | ||
| { | ||
| return new List<string>(); | ||
| return; |
There was a problem hiding this comment.
Suggested change
| return; | |
| return new List<string>(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Async suffix on async operations