Skip to content

fixing selects with same names #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions src/Redis.OM/Common/ExpressionTranslator.cs
Original file line number Diff line number Diff line change
Expand Up @@ -627,14 +627,7 @@ private static ReturnFields TranslateSelectMethod(MethodCallExpression expressio
if (assignment.Expression is MemberExpression assignmentExpression)
{
var path = AliasOrPath(t, attr, assignmentExpression);
if (assignmentExpression.Member.Name == binding.Member.Name)
{
returnFields.Add(new (path));
}
else
{
returnFields.Add(new (path, binding.Member.Name));
}
returnFields.Add(new (path, binding.Member.Name));
}
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/Redis.OM/Redis.OM.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
<RootNamespace>Redis.OM</RootNamespace>
<Nullable>enable</Nullable>
<AutoGenerateBindingRedirects>true</AutoGenerateBindingRedirects>
<PackageVersion>0.5.1</PackageVersion>
<Version>0.5.1</Version>
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.5.1</PackageReleaseNotes>
<PackageVersion>0.5.2</PackageVersion>
<Version>0.5.2</Version>
<PackageReleaseNotes>https://github.com/redis/redis-om-dotnet/releases/tag/v0.5.2</PackageReleaseNotes>
<Description>Object Mapping and More for Redis</Description>
<Title>Redis OM</Title>
<Authors>Steve Lorello</Authors>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1096,13 +1096,19 @@ public void TestSelectOnEmbeddedDocuments()
Assert.Equal(42,resAnonWithAssignments.Field3.InnerInnerCascade.Num);
Assert.Equal("World",resAnonWithAssignments.Field4.InnerInnerCascade.Tag);
Assert.Equal(42,resAnonWithAssignments.Field4.InnerInnerCascade.Num);

var resWithOtherObject = collection.Select(x => new CongruentObject{Field3 = x.Field1, Field4 = x.Field2}).ToList().First();
Assert.Equal("World",resWithOtherObject.Field3.InnerInnerCascade.Tag);
Assert.Equal(42,resWithOtherObject.Field3.InnerInnerCascade.Num);
Assert.Equal("World",resWithOtherObject.Field4.InnerInnerCascade.Tag);
Assert.Equal(42,resWithOtherObject.Field4.InnerInnerCascade.Num);

var resWithOtherObjectLikeNames = collection.Select(x => new CongruentObjectWithLikeNames(){Field1 = x.Field1, Field2 = x.Field2}).ToList().First();
Assert.Equal("World",resWithOtherObjectLikeNames.Field1.InnerInnerCascade.Tag);
Assert.Equal(42,resWithOtherObjectLikeNames.Field1.InnerInnerCascade.Num);
Assert.Equal("World",resWithOtherObjectLikeNames.Field2.InnerInnerCascade.Tag);
Assert.Equal(42,resWithOtherObjectLikeNames.Field2.InnerInnerCascade.Num);

var resNoNew = collection.Select(x => x.Field1).ToList().First();
Assert.Equal("World",resNoNew.InnerInnerCascade.Tag);
Assert.Equal(42,resNoNew.InnerInnerCascade.Num);
Expand Down
6 changes: 6 additions & 0 deletions test/Redis.OM.Unit.Tests/Serialization/SelectTestObject.cs
Original file line number Diff line number Diff line change
Expand Up @@ -16,3 +16,9 @@ public class CongruentObject
public InnerObject Field3 { get; set; }
public InnerObject Field4 { get; set; }
}

public class CongruentObjectWithLikeNames
{
public InnerObject Field1 { get; set; }
public InnerObject Field2 { get; set; }
}