-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Support for specifying error types with retry #1817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1817 +/- ##
==========================================
- Coverage 94.29% 93.96% -0.34%
==========================================
Files 75 75
Lines 15783 15328 -455
==========================================
- Hits 14883 14403 -480
- Misses 900 925 +25
Continue to review full report at Codecov.
|
…on of the nodes manager to stop iterating through startup nodes when the coverage is full
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Given the new retry_on_error having a list value, I really think it's default should be at least, an empty list (see inline).
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
The current client implementation supports only retry on TimeoutError.
Added support for passing specific error types to use with the retry mechanism.
The 'retry_on_timeout' argument has not changed for backward compatibility.
Closes #1764