Skip to content

JSON set_file and set_path support #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 21, 2021
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 20, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Adding the ability to use json.set with a file from disk, or a directory containing multiple json files.

closes #1785

@dvora-h dvora-h requested a review from chayim December 20, 2021 10:20
@chayim chayim changed the title closes #1785 - Set file and set path JSON set_file and set_path support Dec 20, 2021
@chayim chayim added feature New feature 4.1.0 labels Dec 21, 2021
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see suggestions. It's looking good!

@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2021

Codecov Report

Merging #1818 (1757d97) into master (f82ab33) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1818      +/-   ##
==========================================
+ Coverage   94.22%   94.32%   +0.09%     
==========================================
  Files          74       75       +1     
  Lines       15681    15830     +149     
==========================================
+ Hits        14776    14932     +156     
+ Misses        905      898       -7     
Impacted Files Coverage Δ
redis/commands/json/commands.py 88.88% <100.00%> (+2.02%) ⬆️
tests/test_json.py 100.00% <100.00%> (ø)
redis/__init__.py 90.47% <0.00%> (-9.53%) ⬇️
tests/conftest.py 91.13% <0.00%> (-0.75%) ⬇️
tests/test_search.py 98.78% <0.00%> (-0.25%) ⬇️
setup.py 0.00% <0.00%> (ø)
tests/test_ssl.py 91.66% <0.00%> (ø)
tests/test_commands.py 99.38% <0.00%> (+<0.01%) ⬆️
redis/commands/core.py 90.09% <0.00%> (+0.07%) ⬆️
redis/client.py 89.96% <0.00%> (+0.11%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82ab33...1757d97. Read the comment docs.

@chayim chayim self-requested a review December 21, 2021 14:28
@dvora-h dvora-h merged commit 271218e into redis:master Dec 21, 2021
@dvora-h dvora-h deleted the set-file-and-set-path branch December 21, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helper functions to support loading json from files
3 participants