-
Notifications
You must be signed in to change notification settings - Fork 2.6k
JSON set_file and set_path support #1818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see suggestions. It's looking good!
Codecov Report
@@ Coverage Diff @@
## master #1818 +/- ##
==========================================
+ Coverage 94.22% 94.32% +0.09%
==========================================
Files 74 75 +1
Lines 15681 15830 +149
==========================================
+ Hits 14776 14932 +156
+ Misses 905 898 -7
Continue to review full report at Codecov.
|
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Adding the ability to use json.set with a file from disk, or a directory containing multiple json files.
closes #1785