Skip to content

Fixing exception in listen #1823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 22, 2021
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 22, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1788

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2021

Codecov Report

Merging #1823 (931eb03) into master (271218e) will decrease coverage by 0.03%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1823      +/-   ##
==========================================
- Coverage   94.33%   94.30%   -0.04%     
==========================================
  Files          75       75              
  Lines       15830    15837       +7     
==========================================
+ Hits        14934    14935       +1     
- Misses        896      902       +6     
Impacted Files Coverage Δ
redis/client.py 89.87% <50.00%> (-0.10%) ⬇️
tests/conftest.py 90.14% <0.00%> (-0.99%) ⬇️
tests/test_cluster.py 98.67% <0.00%> (-0.13%) ⬇️
redis/cluster.py 90.23% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271218e...931eb03. Read the comment docs.

@chayim chayim added the bug Bug label Dec 22, 2021
@chayim chayim changed the title close #1788 - fixing exception in listen Fixing exception in listen Dec 22, 2021
@chayim chayim merged commit 1bcdf2d into redis:master Dec 22, 2021
@dvora-h dvora-h deleted the exception-in-listen branch December 22, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exception in listen
3 participants