Skip to content

SRTALGO - skip for redis versions greater than 7.0.0 #1831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 26, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

The command is not supported from version 7.0.0 (replaced with the LCS command)

@codecov-commenter
Copy link

codecov-commenter commented Dec 24, 2021

Codecov Report

Merging #1831 (910c678) into master (d6cb997) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1831      +/-   ##
==========================================
+ Coverage   94.32%   94.39%   +0.06%     
==========================================
  Files          75       75              
  Lines       16031    16027       -4     
==========================================
+ Hits        15121    15128       +7     
+ Misses        910      899      -11     
Impacted Files Coverage Δ
tests/test_commands.py 99.39% <100.00%> (+<0.01%) ⬆️
tests/conftest.py 90.14% <0.00%> (-0.99%) ⬇️
tests/test_cluster.py 98.66% <0.00%> (-0.14%) ⬇️
redis/commands/core.py 89.93% <0.00%> (+0.01%) ⬆️
redis/cluster.py 92.04% <0.00%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6cb997...910c678. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Dec 26, 2021
@chayim chayim merged commit f03d008 into redis:master Dec 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants